Add an extra scenario to illustrate the delegation "latency" #1137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KtorZ
force-pushed
the
KtorZ/904/delegate-quit-earn-money
branch
from
411fc25
to
fa090b0
Compare
piotr-iohk
reviewed
Dec 6, 2019
| request @ApiWallet ctx (getWalletEp w) Default Empty >>= flip verify | ||
| [ expectFieldSatisfy balanceReward (> 0) | ||
| ] | ||
|
|
There was a problem hiding this comment.
Maybe it would be worth also to waitForNextEpoch ctx after the last request/assertion and make sure that the rewards are still the same?
KtorZ
force-pushed
the
KtorZ/904/delegate-quit-earn-money
branch
from
e5ff524
to
48ca283
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Dec 9, 2019
1137: Add an extra scenario to illustrate the delegation "latency" r=KtorZ a=KtorZ # Issue Number <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> #904 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] I have added an extra scenario regarding rewards behavior described below # Comments <!-- Additional comments or screenshots to attach if any --> At epoch e: Join stake pool P1 At epoch e+1: Quit stake pool P1 At epoch e+2: Stake is being delegated to P1 At epoch e+3: Reward is earned from the delegation in e+2 <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: KtorZ <matthias.benkort@gmail.com>
Build failed |
|
bors r+ |
|
bors r- |
Canceled |
At epoch e: Join stake pool P1 At epoch e+1: Quit stake pool P1 At epoch e+2: Stake is being delegated to P1 At epoch e+3: Reward is earned from the delegation in e+2
KtorZ
force-pushed
the
KtorZ/904/delegate-quit-earn-money
branch
from
48ca283
to
b70ee87
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Dec 9, 2019
1137: Add an extra scenario to illustrate the delegation "latency" r=KtorZ a=KtorZ # Issue Number <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> #904 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] I have added an extra scenario regarding rewards behavior described below # Comments <!-- Additional comments or screenshots to attach if any --> At epoch e: Join stake pool P1 At epoch e+1: Quit stake pool P1 At epoch e+2: Stake is being delegated to P1 At epoch e+3: Reward is earned from the delegation in e+2 <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: KtorZ <matthias.benkort@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#904
Overview
Comments
At epoch e: Join stake pool P1
At epoch e+1: Quit stake pool P1
At epoch e+2: Stake is being delegated to P1
At epoch e+3: Reward is earned from the delegation in e+2